[webkit-reviews] review requested: [Bug 42534] Crash in Notification::disconnectFrame() triggered by Frame::lifeSupportTimerFired() : [Attachment 62193] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jul 21 09:26:00 PDT 2010
Yael <yael.aharon at nokia.com> has asked for review:
Bug 42534: Crash in Notification::disconnectFrame() triggered by
Frame::lifeSupportTimerFired()
https://bugs.webkit.org/show_bug.cgi?id=42534
Attachment 62193: Patch
https://bugs.webkit.org/attachment.cgi?id=62193&action=review
------- Additional Comments from Yael <yael.aharon at nokia.com>
Added comment about the NULL check, per comment #10.
I am reluctant to add an ASSERT here, because if m_notificationPresenter will
be NULL, Chromium will continue to crash and we will continue to get crash
reports.
I assume these crash reports are generated from debug builds, not release
builds, so the ASSERT will be hit.
More information about the webkit-reviews
mailing list