[webkit-reviews] review requested: [Bug 42534] Crash in Notification::disconnectFrame() triggered by Frame::lifeSupportTimerFired() : [Attachment 62184] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jul 21 08:23:51 PDT 2010
Yael <yael.aharon at nokia.com> has asked for review:
Bug 42534: Crash in Notification::disconnectFrame() triggered by
Frame::lifeSupportTimerFired()
https://bugs.webkit.org/show_bug.cgi?id=42534
Attachment 62184: Patch
https://bugs.webkit.org/attachment.cgi?id=62184&action=review
------- Additional Comments from Yael <yael.aharon at nokia.com>
Call NotificationsCenter::disconnectFrame when a frame is detached from its
page. We want to cancel any outstanding premision requests at that point.
Since I could not reproduce the crash, I did not add tests at this time, but
there is a new test for canceling notifications requests in
https://bugs.webkit.org/show_bug.cgi?id=41413 .
More information about the webkit-reviews
mailing list