[webkit-reviews] review granted: [Bug 42722] WebKit on Windows should build optionally with an unversioned ICU DLL : [Attachment 62143] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Steve Falkenburg
<sfalken at apple.com>'s request for review:
Bug 42722: WebKit on Windows should build optionally with an unversioned ICU
DLL
https://bugs.webkit.org/show_bug.cgi?id=42722

Attachment 62143: Patch
https://bugs.webkit.org/attachment.cgi?id=62143&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> +	   Since the versioned and unversioned ICU have different filenames
(libicuuc.lib vs icuuc.lib)
> +	   we copy the ICU lib to an intermediate location under obj with a
common name.

I think you meant "under lib".

It would be nicer to add a new ICU.vsprops file that contains the ICU-specific
settings (AdditionalDependencies, AdditionalLibraryDirectories,
VCPreLinkEventTool, ForcedIncludes). Then each project that links against ICU
could just include it.

r=me