[webkit-reviews] review granted: [Bug 42244] SVGFilterElement & SVGFE*Element don't support dynamic invalidation, when attributes change : [Attachment 62156] Patch for FilterElement properties (v2)

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has granted Zoltan Herczeg
<zherczeg at webkit.org>'s request for review:
Bug 42244: SVGFilterElement & SVGFE*Element don't support dynamic invalidation,
when attributes change
https://bugs.webkit.org/show_bug.cgi?id=42244

Attachment 62156: Patch for FilterElement properties (v2)
https://bugs.webkit.org/attachment.cgi?id=62156&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
r=me, looks much better! Some quick fixes needed before landing:

LayoutTests/ChangeLog:5
 +	    Testing SVGFilterElement dynamic property changes
The title in the ChangeLog does not correspond to the bug report, either change
the bug title or the ChangeLog, whatever you like.

LayoutTests/svg/dynamic-updates/script-tests/SVGFilterElement-dom-filterRes-att
r.js:1
 +  // [Name] SVGFilterElement-dom-x-attr.js
Name is wrong, please update.

LayoutTests/svg/dynamic-updates/script-tests/SVGFilterElement-dom-filterUnits-a
ttr.js:1
 +  // [Name] SVGFilterElement-dom-x-attr.js
Ditto.

LayoutTests/svg/dynamic-updates/script-tests/SVGFilterElement-dom-height-attr.j
s:1
 +  // [Name] SVGFilterElement-dom-x-attr.js
Ditto.

LayoutTests/svg/dynamic-updates/script-tests/SVGFilterElement-dom-primitiveUnit
s-attr.js:1
 +  // [Name] SVGFilterElement-dom-x-attr.js
Ditto.

LayoutTests/svg/dynamic-updates/script-tests/SVGFilterElement-dom-width-attr.js
:1
 +  // [Name] SVGFilterElement-dom-x-attr.js
Ditto.

LayoutTests/svg/dynamic-updates/script-tests/SVGFilterElement-dom-y-attr.js:1
 +  // [Name] SVGFilterElement-dom-x-attr.js
Ditto.

LayoutTests/svg/dynamic-updates/script-tests/SVGFilterElement-svgdom-filterRes-
call.js:1
 +  // [Name] SVGFilterElement-dom-x-attr.js
Ditto.

LayoutTests/svg/dynamic-updates/script-tests/SVGFilterElement-svgdom-filterResX
-prop.js:1
 +  // [Name] SVGFilterElement-dom-x-attr.js
Ditto.

LayoutTests/svg/dynamic-updates/script-tests/SVGFilterElement-svgdom-filterResY
-prop.js:1
 +  // [Name] SVGFilterElement-dom-x-attr.js
Ditto.

LayoutTests/svg/dynamic-updates/script-tests/SVGFilterElement-svgdom-filterUnit
s-prop.js:1
 +  // [Name] SVGFilterElement-dom-x-attr.js
Ditto.

LayoutTests/svg/dynamic-updates/script-tests/SVGFilterElement-svgdom-height-pro
p.js:1
 +  // [Name] SVGFilterElement-dom-x-attr.js
Ditto.

LayoutTests/svg/dynamic-updates/script-tests/SVGFilterElement-svgdom-primitiveU
nits-prop.js:1
 +  // [Name] SVGFilterElement-dom-x-attr.js
Ditto.

LayoutTests/svg/dynamic-updates/script-tests/SVGFilterElement-svgdom-width-prop
.js:1
 +  // [Name] SVGFilterElement-dom-x-attr.js
Ditto.

LayoutTests/svg/dynamic-updates/script-tests/SVGFilterElement-svgdom-x-prop.js:
1
 +  // [Name] SVGFilterElement-dom-x-attr.js
Ditto.

LayoutTests/svg/dynamic-updates/script-tests/SVGFilterElement-svgdom-y-prop.js:
1
 +  // [Name] SVGFilterElement-dom-x-attr.js
Ditto.