[webkit-reviews] review requested: [Bug 41667] [Qt] QScriptEngine should have an API for creating Date objects : [Attachment 62146] Patch v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 20 22:46:05 PDT 2010


Caio Marcelo de Oliveira Filho <caio.oliveira at openbossa.org> has asked	for
review:
Bug 41667: [Qt] QScriptEngine should have an API for creating Date objects
https://bugs.webkit.org/show_bug.cgi?id=41667

Attachment 62146: Patch v2
https://bugs.webkit.org/attachment.cgi?id=62146&action=review

------- Additional Comments from Caio Marcelo de Oliveira Filho
<caio.oliveira at openbossa.org>
Thanks for the review, Jedrzej.

New version, taking into account the comments:
- QSEP::newDate code duplication removed
- Indentation/style fixed
- Tests properly generated using tools in Qt upstream

And also:
- Make use of the new QScriptOriginalGlobalObject instead of fetching/storing
manually the Date constructor/prototype
- If QDateTime passed in the newDate() is not valid, return an invalid date


More information about the webkit-reviews mailing list