[webkit-reviews] review granted: [Bug 42673] make dump-as-markup work better on subframes and allow dumping a subtree : [Attachment 62114] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jul 20 15:15:07 PDT 2010
Darin Adler <darin at apple.com> has granted Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 42673: make dump-as-markup work better on subframes and allow dumping a
subtree
https://bugs.webkit.org/show_bug.cgi?id=42673
Attachment 62114: Patch
https://bugs.webkit.org/attachment.cgi?id=62114&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
> +// FIXME: Make description required
Is this really important?
> +/**
> + * The description of what this test is testing. Gets prepended to the
dumped markup.
> + */
Why not use // comments everywhere as we do elsewhere in WebKit?
All looks fine.
More information about the webkit-reviews
mailing list