[webkit-reviews] review granted: [Bug 42668] Fix fast/dom/title-content-write-set.html for HTML5 tree builder : [Attachment 62113] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 20 14:50:48 PDT 2010


Darin Adler <darin at apple.com> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 42668: Fix fast/dom/title-content-write-set.html for HTML5 tree builder
https://bugs.webkit.org/show_bug.cgi?id=42668

Attachment 62113: Patch
https://bugs.webkit.org/attachment.cgi?id=62113&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> -PassRefPtr<StringImpl> CharacterData::parserAppendData(const String& arg)
> +PassRefPtr<StringImpl> CharacterData::appendDataCommon(const String& arg)

> +void CharacterData::parserAppendData(const String& arg)

> +    PassRefPtr<StringImpl> appendDataCommon(const String& arg);

Please omit the name "arg" here. It doesn't add anything.


More information about the webkit-reviews mailing list