[webkit-reviews] review granted: [Bug 42670] Would like a way to break into the debugger when the web process launches : [Attachment 62112] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Adam Roben (aroben)
<aroben at apple.com>'s request for review:
Bug 42670: Would like a way to break into the debugger when the web process
launches
https://bugs.webkit.org/show_bug.cgi?id=42670

Attachment 62112: Patch
https://bugs.webkit.org/attachment.cgi?id=62112&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
>  extern "C" __declspec(dllexport) 
>  int WebKitMain(HINSTANCE hInstance, HINSTANCE hPrevInstance, LPTSTR
lpstrCmdLine, int nCmdShow)
>  {

Please add a comment here indicating the key combination and what this does.
Can ::GetKeyState change between calls? If so, should you keep it in a
variable?

> +#ifndef NDEBUG
> +    const unsigned short highBitMaskShort = 0x8000;
> +    if ((::GetKeyState(VK_CONTROL) & highBitMaskShort) &&
(::GetKeyState(VK_MENU) & highBitMaskShort) && (::GetKeyState(VK_SHIFT) &
highBitMaskShort))
> +	   DebugBreak();

This should be ::DebugBreak().