[webkit-reviews] review granted: [Bug 41531] Asynchronous cross origin XMLHttpRequest doesn't expose 401 response when withCredentials is false : [Attachment 61999] proposed fix
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jul 20 12:21:27 PDT 2010
Brady Eidson <beidson at apple.com> has granted Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 41531: Asynchronous cross origin XMLHttpRequest doesn't expose 401 response
when withCredentials is false
https://bugs.webkit.org/show_bug.cgi?id=41531
Attachment 61999: proposed fix
https://bugs.webkit.org/attachment.cgi?id=61999&action=review
------- Additional Comments from Brady Eidson <beidson at apple.com>
> Index: WebCore/ChangeLog
> ===================================================================
> +
> + * loader/DocumentThreadableLoader.cpp:
> +
(WebCore::DocumentThreadableLoader::didReceiveAuthenticationChallenge): Instead
of canceling
> + the request, continue withotu credentials - if the platform has a
necessary method on
> + ResourceHandle.
typo "withotu"
> +
> + * loader/SubresourceLoader.cpp:
> + (WebCore::SubresourceLoader::didReceiveAuthenticationChallenge):
Don't ask resource laoder
> + client for credentials if subresource laoder client already resolved
those.
typo "laoder"
Otherwise seems fine!
More information about the webkit-reviews
mailing list