[webkit-reviews] review requested: [Bug 42613] WebScriptObject Should Allow Safely Checking For Key Existence : [Attachment 62090] [PATCH] Addressed Comments
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jul 20 10:33:39 PDT 2010
Joseph Pecoraro <joepeck at webkit.org> has asked for review:
Bug 42613: WebScriptObject Should Allow Safely Checking For Key Existence
https://bugs.webkit.org/show_bug.cgi?id=42613
Attachment 62090: [PATCH] Addressed Comments
https://bugs.webkit.org/attachment.cgi?id=62090&action=review
------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
(In reply to comment #3)
> This new method should not be added to the public header until it has been
through API review.
> Until that time it should be added in the private header in a category on the
class named to
> indicate that it’s pending API review.
Done. I put a "forward declaring @interface" in DRT, should I export the
Private header instead?
(In reply to comment #4)
> (From update of attachment 62031 [details])
> I’m also not keen on the location you chose for the test case. The test has
nothing to do
> with plugins as far as I can tell.
Ahh, you're correct. I moved it to "LayoutTests/platform/mac/fast/objc/".
More information about the webkit-reviews
mailing list