[webkit-reviews] review granted: [Bug 42634] [v8] Allow handles to be disposed and WebKit objects to be dereferenced even if their map is already destroyed. : [Attachment 62075] Shorter

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 20 08:54:51 PDT 2010


Adam Barth <abarth at webkit.org> has granted anton muhin <antonm at chromium.org>'s
request for review:
Bug 42634: [v8] Allow handles to be disposed and WebKit objects to be
dereferenced even if their map is already destroyed.
https://bugs.webkit.org/show_bug.cgi?id=42634

Attachment 62075: Shorter
https://bugs.webkit.org/attachment.cgi?id=62075&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Yeah, I like this approach better than introducing additional weak callbacks. 
This code is really complicated.  I wish there was an easier (i.e., more
automatic) way of handling this stuff.	All this manually
ref()/deref()/Dispose() business is bad news bears.  Keeps the weak
relationships in sync is really tricky.

I think this patch is correct.	Thanks for working in this area.


More information about the webkit-reviews mailing list