[webkit-reviews] review granted: [Bug 22556] console.assert should include stack trace with line numbers. : [Attachment 62079] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 22556: console.assert should include stack trace with line numbers.
https://bugs.webkit.org/show_bug.cgi?id=22556

Attachment 62079: Patch
https://bugs.webkit.org/attachment.cgi?id=62079&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
WebCore/bindings/v8/ScriptCallStack.cpp:56
 +	if (stackTrace->GetFrameCount() <= 0) {
<=? Should it be == 0?

WebCore/bindings/v8/ScriptCallStack.cpp:59
 +	    *sourceName = toWebCoreString(v8::Undefined());
"undefined"?

WebCore/bindings/v8/ScriptCallStack.cpp:61
 +	    *functionName = toWebCoreString(v8::Undefined());
"undefined"?