[webkit-reviews] review denied: [Bug 42244] SVGFilterElement & SVGFE*Element don't support dynamic invalidation, when attributes change : [Attachment 62060] Patch for FilterElement properties

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has denied Zoltan Herczeg
<zherczeg at webkit.org>'s request for review:
Bug 42244: SVGFilterElement & SVGFE*Element don't support dynamic invalidation,
when attributes change
https://bugs.webkit.org/show_bug.cgi?id=42244

Attachment 62060: Patch for FilterElement properties
https://bugs.webkit.org/attachment.cgi?id=62060&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
Looks great, I have some suggestions though:
It would be great, if all results would end up with the _same_ image. It's much
easier to spot breakages, if the expected pngs would all look the same, if the
invalidation worked properly - can you change that?
(Are you aware of make-script-test-wrappers, btw? That automatically creates
the .html files for you)

LayoutTests/svg/dynamic-updates/script-tests/SVGFilterElement-svgdom-filterRes-
call.js:45
 +	filterElement.setFilterRes("400", "400");
These take numbers, you can omit the ".

LayoutTests/svg/dynamic-updates/script-tests/SVGFilterElement-svgdom-filterResX
-prop.js:44
 +	filterElement.filterResX.baseVal = "400";
Ditto.

LayoutTests/svg/dynamic-updates/script-tests/SVGFilterElement-svgdom-filterResY
-prop.js:44
 +	filterElement.filterResY.baseVal = "400";
Ditto.

LayoutTests/svg/dynamic-updates/script-tests/SVGFilterElement-svgdom-height-pro
p.js:43
 +	filterElement.height.baseVal.value = "200";
Ditto.

LayoutTests/svg/dynamic-updates/script-tests/SVGFilterElement-svgdom-width-prop
.js:43
 +	filterElement.width.baseVal.value = "200";
Ditto.

LayoutTests/svg/dynamic-updates/script-tests/SVGFilterElement-svgdom-x-prop.js:
43
 +	filterElement.x.baseVal.value = "10";
Ditto.

LayoutTests/svg/dynamic-updates/script-tests/SVGFilterElement-svgdom-y-prop.js:
43
 +	filterElement.y.baseVal.value = "10";
Ditto.