[webkit-reviews] review denied: [Bug 42068] Need to be able to configure Geolocation policy regarding user permissions : [Attachment 62044] patch

[bugzilla-daemon at webkit.org]

Steve Block <steveblock at google.com> has denied Mahesh Kulkarni
<mahesh.kulkarni at nokia.com>'s request for review:
Bug 42068: Need to be able to configure Geolocation policy regarding user
permissions
https://bugs.webkit.org/show_bug.cgi?id=42068

Attachment 62044: patch
https://bugs.webkit.org/attachment.cgi?id=62044&action=review

------- Additional Comments from Steve Block <steveblock at google.com>
WebCore/page/Geolocation.cpp:643
 +  #endif 
Trailing whitespace

WebCore/page/Geolocation.cpp:421
 +		m_startRequestPermissionNotifier = 0;
This new block wasn't in the first patch and introduces a change in behaviour.
This bug was intended to add the new USE flag and not introduce any functional
changes. This block should be part of the fix for your original Bug 42027.

JavaScriptCore/wtf/Platform.h:1120
 +  #if ENABLE(CLIENT_BASED_GEOLOCATION)
I still think a comment describing the currently supported permutations would
be good.

It looks like you still plan to use the non-client-based implementation on Qt?
It would be great of you could go straight for the client-based approach.