[webkit-reviews] review requested: [Bug 40197] Enhance the hit testing to take a rectangle instead of a point : [Attachment 62029] patch v3 - feature + tests

[bugzilla-daemon at webkit.org]

Antonio Gomes <tonikitoo at webkit.org> has asked	for review:
Bug 40197: Enhance the hit testing to take a rectangle instead of a point
https://bugs.webkit.org/show_bug.cgi?id=40197

Attachment 62029: patch v3 - feature + tests
https://bugs.webkit.org/attachment.cgi?id=62029&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
Difference from patch v2 (attachment 60772):

- Fixed a bug where input elements were not being hit at all:
HitTestResult::addRawNodeForRegionTest is no-op if null'ed Node is passed as
parameter, however it was returning 'false', which means that hit test should
stop. Now it is returning the proper value (i.e. true) and subsequent hit test
processing keeps happenning.

- Fixed an unconditional behavior change in EventHandler::hitTestResultAtPoint:
receiving a zero-padding (IntSize(0,0)) still performs a rect-based hit test.
The logic was then adapted to consider negative paddings as invalid for rect
hit testing purposes.

- Better changeLog entry: it is now more descriptive.