[webkit-reviews] review granted: [Bug 42597] [Qt] Add API to define device-width and height for use with the viewport meta tag : [Attachment 62002] Patch 2

[bugzilla-daemon at webkit.org]

Antonio Gomes <tonikitoo at webkit.org> has granted Kenneth Rohde Christiansen
<kenneth at webkit.org>'s request for review:
Bug 42597: [Qt] Add API to define device-width and height for use with the
viewport meta tag
https://bugs.webkit.org/show_bug.cgi?id=42597

Attachment 62002: Patch 2
https://bugs.webkit.org/attachment.cgi?id=62002&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
Looks good.

You are missing the \since 4.x below.
>  /*!
> +    \property QGraphicsWebView::deviceSize
> +    \brief the size of the device using the web view
> +
> +    The device size is used by the DOM window object methods
> +    otherHeight(), otherWidth() as well as a page for the viewport
> +    meta tag attributes device-width and device-height.
> +*/
> +void QGraphicsWebView::setDeviceSize(QSize size)

const QSize&

> +QSize QGraphicsWebView::deviceSize()

const it, please.

> +    QSize deviceSize();
const.

> +    void setDeviceSize(QSize);
const QSize&