[webkit-reviews] review requested: [Bug 42202] [chromium] crash in Position::getInlineBoxAndOffset : [Attachment 62012] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 19 16:57:33 PDT 2010


Tony Chang (Google) <tony at chromium.org> has asked  for review:
Bug 42202: [chromium] crash in Position::getInlineBoxAndOffset
https://bugs.webkit.org/show_bug.cgi?id=42202

Attachment 62012: Patch
https://bugs.webkit.org/attachment.cgi?id=62012&action=review

------- Additional Comments from Tony Chang (Google) <tony at chromium.org>
Ojan was right, we need to null check the visibleposition or we crash when it
is null.  I added a manual test for this case (it uses the contextmenu key on
windows).


More information about the webkit-reviews mailing list