[webkit-reviews] review denied: [Bug 42589] Canvas Layout Tests directory cleanup : [Attachment 62001] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 19 15:36:57 PDT 2010


Sam Weinig <sam at webkit.org> has denied Matthew Delaney <mdelaney at apple.com>'s
request for review:
Bug 42589: Canvas Layout Tests directory cleanup
https://bugs.webkit.org/show_bug.cgi?id=42589

Attachment 62001: Patch
https://bugs.webkit.org/attachment.cgi?id=62001&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>

> +	   Copying over test resource files for canvas security tests in their
new appropriate location.
> +	   * http/tests/security/resources/tests.css: Added.
> +	   (html.fail):
> +	   (html.pass):
> +	   (html.needs_check):
> +	   (body):
> +	   (a:link):
> +	   (a:visited):
> +	   (body.framed):
> +	   (h1):
> +	   (p):
> +	   (p.notes):
> +	   (ul):
> +	   (.refs):
> +	   (.refs ul):
> +	   (.refs li):
> +	   (canvas):
> +	   (img.expected):
> +	   (iframe):
> +	   (.output):
> +	   (.show_output .output, .needs_check .output):
> +	   (.show_output #show_output):
> +	   (.resource):
> +	   (.fallback):
> +	   (html.minimal body):
> +	   (html.fail.minimal):
> +	   (html.pass.minimal):
> +	   (html.needs_check.minimal):
> +	   (.minimal #d):
> +	   (.minimal .expectedtext):
> +	   (#passtext, #failtext):
> +	   (.minimal.pass #passtext, .minimal.fail #failtext):
> +	   * http/tests/security/resources/tests.js: Added.
> +	   (_valToString):
> +	   (_hex2dec):
> +	   (_warn):
> +	   (_fail):
> +	   (_assert):
> +	   (_assertSame):
> +	   (_assertDifferent):
> +	   (_assertEqual):
> +	   (_assertMatch):
> +	   (_requireManualCheck):
> +	   (_crash):
> +	   (_getPixel):
> +	   (_assertPixel):
> +	   (_assertPixelApprox):
> +	   (_addTest.window.deferTest):
> +	   (_addTest.endTest):
> +	   (_addTest.window.wrapFunction.return.try):
> +	   (_addTest.window.wrapFunction):
> +	   (_addTest.window.onload):
> +	   (_addTest):

Please remove this gunk.


More information about the webkit-reviews mailing list