[webkit-reviews] review granted: [Bug 42512] [Web Timing] Move times to DocumentLoader and fix bugs in mark points : [Attachment 61906] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 19 13:50:19 PDT 2010


Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Tony Gentilcore
<tonyg at chromium.org>'s request for review:
Bug 42512: [Web Timing] Move times to DocumentLoader and fix bugs in mark
points
https://bugs.webkit.org/show_bug.cgi?id=42512

Attachment 61906: Patch
https://bugs.webkit.org/attachment.cgi?id=61906&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
WebCore/loader/DocumentLoader.h:208
 +	    DocumentLoadTiming* documentLoadTiming() { return
&m_documentLoadTiming; }
one minor suggestion: you could probably get away with shortening this member
function to "timing()" as the "documentLoad" prefix is sort of redundant with
the
name of the class, DocumentLoader.

R=me


More information about the webkit-reviews mailing list