[webkit-reviews] review granted: [Bug 42093] Change handling of -khtml- and -apple- vendor-prefixes : [Attachment 61779] Patch reduced to removing -khtml and limiting -apple

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Peter Beverloo
<peter at lvp-media.com>'s request for review:
Bug 42093: Change handling of -khtml- and -apple- vendor-prefixes
https://bugs.webkit.org/show_bug.cgi?id=42093

Attachment 61779: Patch reduced to removing -khtml and limiting -apple
https://bugs.webkit.org/attachment.cgi?id=61779&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +	       // -webkit-border-*-*-radius worked in Safari 4 and earlier.
-webkit-border-radius syntax
> +	       // differs from border-radius, so it is remains as a distinct
property.

As long as you are moving this code, we should consider fixing "it is remains"
here.

> +	   // If the prefix is -apple, support two properties to maintain
> +	   // backward compatibility with older versions of Safari.
> +	   if (!strcmp(buffer, "-apple-dashboard-region") || !strcmp(buffer,
"-apple-line-clamp")) {

This comment isn’t quite right. The most important context for this is not
Safari itself, but rather Dashboard. But I suppose we are OK with the comment
as-is.