[webkit-reviews] review granted: [Bug 42586] Log all canceled authentication attempts in DumpRenderTree : [Attachment 61980] proposed patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 42586: Log all canceled authentication attempts in DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=42586

Attachment 61980: proposed patch
https://bugs.webkit.org/attachment.cgi?id=61980&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +	   NSString *string = [NSString stringWithFormat:@"%@ -
didReceiveAuthenticationChallenge - Simulating cancelled authentication sheet",
identifier];
> +	   printf("%s\n", [string UTF8String]);

I would either use puts instead of printf here, or continue to use printf but
use UTF8String on the identifier instead of calling stringWithFormat and have a
printf format string instead.

r=me