[webkit-reviews] review granted: [Bug 42278] Removes DontCheckEnums from some IDLs and fixes the corresponding enums. : [Attachment 61945] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 19 11:01:25 PDT 2010


Darin Adler <darin at apple.com> has granted Marcus Bulach <bulach at chromium.org>'s
request for review:
Bug 42278: Removes DontCheckEnums from some IDLs and fixes the corresponding
enums.
https://bugs.webkit.org/show_bug.cgi?id=42278

Attachment 61945: Patch
https://bugs.webkit.org/attachment.cgi?id=61945&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Seems to me that having a test that actually tests the integer values was
valuable. Too bad it was expecting the wrong values! Changing the test to use
the named constants makes the test more readable, but changes what it tests.


More information about the webkit-reviews mailing list