[webkit-reviews] review granted: [Bug 42532] Auto-generate the JS bindings for WebKitTestRunner's script objects : [Attachment 61922] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jul 19 09:35:53 PDT 2010
Adam Roben (aroben) <aroben at apple.com> has granted Sam Weinig
<sam at webkit.org>'s request for review:
Bug 42532: Auto-generate the JS bindings for WebKitTestRunner's script objects
https://bugs.webkit.org/show_bug.cgi?id=42532
Attachment 61922: Patch
https://bugs.webkit.org/attachment.cgi?id=61922&action=review
------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
It looks like _nullStringPolicy isn't needed. It's only called in one place,
and its result is never used.
It looks like _monthDayYearString isn't needed.
What about Windows?
Maybe JSWrapper should be a namespace rather than a class?
r=me other than those concerns.
More information about the webkit-reviews
mailing list