[webkit-reviews] review denied: [Bug 42234] Implementing VideoLayerChromium for gpu acceleration : [Attachment 61870] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jul 19 09:31:17 PDT 2010
David Levin <levin at chromium.org> has denied Victoria <vrk at google.com>'s request
for review:
Bug 42234: Implementing VideoLayerChromium for gpu acceleration
https://bugs.webkit.org/show_bug.cgi?id=42234
Attachment 61870: Patch
https://bugs.webkit.org/attachment.cgi?id=61870&action=review
------- Additional Comments from David Levin <levin at chromium.org>
In addition to my (minor) comment below:
1. Please figure out the chromium build break. (You may need a DEPS roll.)
2. It would be nice to get Alpha to look it over again.
> diff --git a/WebKit/chromium/src/WebMediaPlayerClientImpl.cpp
b/WebKit/chromium/src/WebMediaPlayerClientImpl.cpp
> WebMediaPlayerClientImpl::WebMediaPlayerClientImpl()
> : m_mediaPlayer(0)
> +#if USE(ACCELERATED_COMPOSITING)
> + ,
> + m_videoLayer(0),
> + m_supportsAcceleratedCompositing(false)
The commas should be at the beginning of the lines (and this will happen to
make the formatting more uniform).
More information about the webkit-reviews
mailing list