[webkit-reviews] review granted: [Bug 42560] Web Inspector: show stack trace for uncaught exceptions : [Attachment 61943] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 42560: Web Inspector: show stack trace for uncaught exceptions
https://bugs.webkit.org/show_bug.cgi?id=42560

Attachment 61943: Patch
https://bugs.webkit.org/attachment.cgi?id=61943&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
It looks correct, however, I think we've reached the critical mass of mess in
the code. Can we refactor it to make prettier?

My concern is that ScriptCallStack means two different things in different call
paths: 
(1) it is used as a top frame + script state for console.log/dir/etc
(2) it is used as a stack container with no access to top frame arguments in
regular console messages