[webkit-reviews] review granted: [Bug 42527] [Qt] tst_QWebElement fails firstChildNextSibling and lastChildPreviousSibling : [Attachment 61915] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jul 18 15:49:20 PDT 2010


Antonio Gomes <tonikitoo at webkit.org> has granted Andreas Kling
<andreas.kling at nokia.com>'s request for review:
Bug 42527: [Qt] tst_QWebElement fails firstChildNextSibling and
lastChildPreviousSibling
https://bugs.webkit.org/show_bug.cgi?id=42527

Attachment 61915: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=61915&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
> diff --git a/WebKit/qt/ChangeLog b/WebKit/qt/ChangeLog
> index efbee15..31b488f 100644
> --- a/WebKit/qt/ChangeLog
> +++ b/WebKit/qt/ChangeLog
> @@ -1,3 +1,16 @@
> +2010-07-18  Andreas Kling  <andreas.kling at nokia.com>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   [Qt] tst_QWebElement fails firstChildNextSibling and
lastChildPreviousSibling
> +	   https://bugs.webkit.org/show_bug.cgi?id=42527
> +
> +	   Correct the HTML used by these tests.
> +
> +	   * tests/qwebelement/tst_qwebelement.cpp:
> +	   (tst_QWebElement::firstChildNextSibling):
> +	   (tst_QWebElement::lastChildPreviousSibling):
> +
>  2010-07-16  Zhe Su  <suzhe at chromium.org>
>  
>	   Reviewed by Darin Adler.
> diff --git a/WebKit/qt/tests/qwebelement/tst_qwebelement.cpp
b/WebKit/qt/tests/qwebelement/tst_qwebelement.cpp
> index 8db0ec3..2f1097a 100644
> --- a/WebKit/qt/tests/qwebelement/tst_qwebelement.cpp
> +++ b/WebKit/qt/tests/qwebelement/tst_qwebelement.cpp
> @@ -887,7 +887,7 @@ void tst_QWebElement::nullSelect()
>  
>  void tst_QWebElement::firstChildNextSibling()
>  {
> -    m_mainFrame->setHtml("<body><!--comment--><p>Test</p><!--another
commend><table>");
> +    m_mainFrame->setHtml("<body><!--comment--><p>Test</p><!--another
comment--><table>");
>  
>      QWebElement body = m_mainFrame->findFirstElement("body");
>      QVERIFY(!body.isNull());
> @@ -902,7 +902,7 @@ void tst_QWebElement::firstChildNextSibling()
>  
>  void tst_QWebElement::lastChildPreviousSibling()
>  {
> -    m_mainFrame->setHtml("<body><!--comment--><p>Test</p><!--another
commend><table>");
> +    m_mainFrame->setHtml("<body><!--comment--><p>Test</p><!--another
comment--><table>");
>  
>      QWebElement body = m_mainFrame->findFirstElement("body");
>      QVERIFY(!body.isNull());


More information about the webkit-reviews mailing list