[webkit-reviews] review granted: [Bug 42526] More NPRuntime work : [Attachment 61914] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jul 18 15:22:38 PDT 2010


Sam Weinig <sam at webkit.org> has granted Anders Carlsson <andersca at apple.com>'s
request for review:
Bug 42526: More NPRuntime work
https://bugs.webkit.org/show_bug.cgi?id=42526

Attachment 61914: Patch
https://bugs.webkit.org/attachment.cgi?id=61914&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
> +    static bool NP_HasProperty(NPObject *npobj, NPIdentifier name);
> +    static bool NP_GetProperty(NPObject *npobj, NPIdentifier name, NPVariant
*result);

* on the wrong side.

> +
> +    const char *string = identifierRep->string();

* on the wrong side.

Otherwise, r=me.


More information about the webkit-reviews mailing list