[webkit-reviews] review denied: [Bug 42523] Web Inspector: the bindings generation helper script can be simplified a bit. Chromium. : [Attachment 61909] [patch] initial version.

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 42523: Web Inspector: the bindings generation helper script can be
simplified a bit. Chromium.
https://bugs.webkit.org/show_bug.cgi?id=42523

Attachment 61909: [patch] initial version.
https://bugs.webkit.org/attachment.cgi?id=61909&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
A bunch of nits to fix.

WebCore/WebCore.gyp/scripts/rule_binding.py:124
 +	command.extend(['--outputHDir', hdir])
Here and below outputHeadersDir

WebCore/WebCore.gyp/scripts/rule_binding.py: 
 +	# Both the .cpp and .h were generated in cppdir, but if hdir is
different,
Can you avoid changing this behavior?

WebCore/bindings/scripts/CodeGenerator.pm:112
 +	$codeGenerator = $ifaceName->new($object, $useOutputDir,
$useLayerOnTop, $preprocessor, $writeDependencies, $verbose, $useOutputHDir);
I'd keep useOutputDir and useOutputHeadersDir next to each other.

WebCore/inspector/CodeGeneratorInspector.pm:282
 +	open(my $HEADER, ">$outputHDir/$frontendClassName.h") || die "Couldn't
open file $outputDir/$frontendClassName.h";
print HeadersDir, not Dir in the message.