[webkit-reviews] review denied: [Bug 42379] Web Inspector: Rename method for CSS rule source range retrieval and fix return object format : [Attachment 61676] [PATCH] Suggested solution

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 42379: Web Inspector: Rename method for CSS rule source range retrieval and
fix return object format
https://bugs.webkit.org/show_bug.cgi?id=42379

Attachment 61676: [PATCH] Suggested solution
https://bugs.webkit.org/attachment.cgi?id=61676&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
WebCore/inspector/InspectorCSSStore.cpp:141
 +	    return result;
Nit: I'd suggest not using result here and moving declaration to where it is
used (bottom of this method).

WebCore/inspector/InspectorCSSStore.cpp:149
 +	    result.set(bindStyle(rule->style()), offsetVector->at(ruleIndex));
I think binding rule makes more sense. Why did this change? r- here unless you
explain please!