[webkit-reviews] review granted: [Bug 42516] Add dumping of statusbar text to WebKitTestRunner : [Attachment 61902] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Jul 18 09:51:46 PDT 2010
mitz at webkit.org has granted Anders Carlsson <andersca at apple.com>'s request for
review:
Bug 42516: Add dumping of statusbar text to WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=42516
Attachment 61902: Patch
https://bugs.webkit.org/attachment.cgi?id=61902&action=review
------- Additional Comments from mitz at webkit.org
> typedef void (*WKBundlePageAddMessageToConsoleCallback)(WKBundlePageRef
page, WKStringRef message, uint32_t lineNumber, const void *clientInfo);
Star on the wrong side of the space here.
> +typedef void (*WKBundlePageSetStatusbarTextCallback)(WKBundlePageRef page,
WKStringRef statusbarText, const void *clientInfo);
and here
> const void *
clientInfo;
and here
> +void InjectedBundlePage::_setStatusbarText(WKBundlePageRef page, WKStringRef
statusbarText, const void *clientInfo)
and here
> static void _addMessageToConsole(WKBundlePageRef page, WKStringRef
message, uint32_t lineNumber, const void *clientInfo);
and here
> + static void _setStatusbarText(WKBundlePageRef page, WKStringRef
statusbarText, const void *clientInfo);
and here
r=me if you fix the style issues.
More information about the webkit-reviews
mailing list