[webkit-reviews] review granted: [Bug 40112] Database callbacks are made using the ScriptExecutionContext of the frame that owns the Database object, rather than that of the caller : [Attachment 59751] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jul 17 16:40:55 PDT 2010


Adam Barth <abarth at webkit.org> has granted Dumitru Daniliuc
<dumi at chromium.org>'s request for review:
Bug 40112: Database callbacks are made using the ScriptExecutionContext of the
frame that owns the Database object, rather than that of the caller
https://bugs.webkit.org/show_bug.cgi?id=40112

Attachment 59751: patch
https://bugs.webkit.org/attachment.cgi?id=59751&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
This patch is definitely an improvement.  It might take a little tweaking to
get perfect, but that's fine.  Thanks for sticking with it.  Please think about
my comments before landing.

WebCore/bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp: 
 +	RefPtr<ScriptExecutionContext> protector(context);
Why don't we need this anymore?


More information about the webkit-reviews mailing list