[webkit-reviews] review requested: [Bug 25898] [Gtk] object:text-changed events should be emitted for entries and password text : [Attachment 61880] 2. New functions in AXObjectCache to call when text changes in a node

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <msanchez at igalia.com> has asked  for review:
Bug 25898: [Gtk] object:text-changed events should be emitted for entries and
password text
https://bugs.webkit.org/show_bug.cgi?id=25898

Attachment 61880: 2. New functions in AXObjectCache to call when text changes
in a node
https://bugs.webkit.org/attachment.cgi?id=61880&action=review

------- Additional Comments from Mario Sanchez Prada <msanchez at igalia.com>
(In reply to comment #32)
> (In reply to comment #31)
> > (In reply to comment #30)
> > > Attachment 61861 [details] [details] [details] did not build on chromium:

> > > Build output: http://webkit-commit-queue.appspot.com/results/3378507
> > 
> > Can you fix this build failure for chromium
> 
> can't remember right now if chromium has their own AXObjectCache version that
needs to be updated

You're right, sorry for not realizing before:

  $ find . -name "AXObject*"
  ./WebCore/accessibility/gtk/AXObjectCacheAtk.cpp
  ./WebCore/accessibility/mac/AXObjectCacheMac.mm
  ./WebCore/accessibility/chromium/AXObjectCacheChromium.cpp
  ./WebCore/accessibility/win/AXObjectCacheWin.cpp
  ./WebCore/accessibility/AXObjectCache.cpp
  ./WebCore/accessibility/AXObjectCache.h

Added dummy implementation for chromium in the patch being attached now (as the
root problem actually belonged to patch 61859, not 61861)

(In reply to comment #37)
> > 
> > Full output: http://webkit-commit-queue.appspot.com/results/3365513
> 
>
/Users/eseidel/Projects/CommitQueue/WebCore/accessibility/mac/AXObjectCacheMac.
mm:117: warning: unused parameter 'object'
>
/Users/eseidel/Projects/CommitQueue/WebCore/accessibility/mac/AXObjectCacheMac.
mm:117: warning: unused parameter 'textChange'
>
/Users/eseidel/Projects/CommitQueue/WebCore/accessibility/mac/AXObjectCacheMac.
mm:117: warning: unused parameter 'offset'
>
/Users/eseidel/Projects/CommitQueue/WebCore/accessibility/mac/AXObjectCacheMac.
mm:117: warning: unused parameter 'count'
> 
> please submit a new patch

Damm it... I didn't realize about the function header's params, sorry. Fixed in
this patch for all dummy implementations (mac, win and chromium), as well as
the inline declarations in AXObjectCache.h for those platforms which
!HAVE(ACCESSIBILITY)

Sorry for the inconvenience... working till very late yesterday :-)