[webkit-reviews] review requested: [Bug 42495] Canvas: Re-use existing CanvasStyle objects for color strings : [Attachment 61876] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 16 23:00:09 PDT 2010


Andreas Kling <andreas.kling at nokia.com> has asked  for review:
Bug 42495: Canvas: Re-use existing CanvasStyle objects for color strings
https://bugs.webkit.org/show_bug.cgi?id=42495

Attachment 61876: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=61876&action=review

------- Additional Comments from Andreas Kling <andreas.kling at nokia.com>
Benchmarking with Hixie's skeleton test:
http://hixie.ch/tests/adhoc/perf/video/002.html

BEFORE:

Elapsed wall-clock time: 819ms (ideal: 640ms).
Elapsed non-idle time: 179ms (ideal: 0ms).
Speed: 18.32fps (ideal: 25.00fps).

AFTER:

Elapsed wall-clock time: 810ms (ideal: 640ms).
Elapsed non-idle time: 170ms (ideal: 0ms).
Speed: 18.52fps (ideal: 25.00fps).


More information about the webkit-reviews mailing list