[webkit-reviews] review requested: [Bug 32530] QtWebkit creates an unnecessary deep copy of images when canvas drawing is done : [Attachment 61866] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 16 18:03:42 PDT 2010


Andreas Kling <andreas.kling at nokia.com> has asked  for review:
Bug 32530: QtWebkit creates an unnecessary deep copy of images when canvas
drawing is done
https://bugs.webkit.org/show_bug.cgi?id=32530

Attachment 61866: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=61866&action=review

------- Additional Comments from Andreas Kling <andreas.kling at nokia.com>
Image* ImageBuffer::imageForRendering()

This method returns an image that can be used for rendering right now (i.e the
QPixmap backing our canvas rendering context.) This lets us avoid the QPixmap
copy due to a painter always being active.

For all other ports, it simply returns ImageBuffer::image();


More information about the webkit-reviews mailing list