[webkit-reviews] review granted: [Bug 42220] [chromium] Subpixel rendering always disabled on Linux : [Attachment 61835] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Daniel Erat <derat at google.com>'s
request for review:
Bug 42220: [chromium] Subpixel rendering always disabled on Linux
https://bugs.webkit.org/show_bug.cgi?id=42220

Attachment 61835: Patch
https://bugs.webkit.org/attachment.cgi?id=61835&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
> +++ b/LayoutTests/ChangeLog
> +	   Layout test addition to check that Chromium Linux honors fontconfig
> +	   settings enabling or disabling subpixel rendering per-strike.
> +
> +	   Subpixel rendering always disabled for Chromium Linux
> +	   https://bugs.webkit.org/show_bug.cgi?id=42220

Nit: the detailed description should go below the bug line, i.e.:

> +	   Subpixel rendering always disabled for Chromium Linux
> +	   https://bugs.webkit.org/show_bug.cgi?id=42220
> +
> +	   Layout test addition to check that Chromium Linux honors fontconfig
> +	   settings enabling or disabling subpixel rendering per-strike.

> +++ b/WebCore/ChangeLog
> @@ -1,3 +1,16 @@
> +	   Initialize global Chromium Linux isSkiaSubpixelGlyphs flag to false.

> +	   (I believe that Chromium is always initializing this before using
> +	   it, but it scares me all the same.)
> +
> +	   Subpixel rendering always disabled for Chromium Linux
> +	   https://bugs.webkit.org/show_bug.cgi?id=42220

Ditto.

> +	   Honor Fontconfig subpixel rendering setting on Chromium Linux.
> +
> +	   Subpixel rendering always disabled for Chromium Linux
> +	   https://bugs.webkit.org/show_bug.cgi?id=42220

And same here. :)

When you've made these changes, you can post a new patch and any committer can
set cq+ to put it in the commit queue. No need for another review.