[webkit-reviews] review denied: [Bug 41318] GC should reclaim garbage even when new objects are not being allocated rapidly : [Attachment 61411] Patch (with smart pointers)

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has denied Nathan Lawrence
<nlawrence at apple.com>'s request for review:
Bug 41318: GC should reclaim garbage even when new objects are not being
allocated rapidly
https://bugs.webkit.org/show_bug.cgi?id=41318

Attachment 61411: Patch (with smart pointers)
https://bugs.webkit.org/attachment.cgi?id=61411&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
I think the callback invocation should be inside reset(), so that the timer is
active even after events like collections due to extra cost.

It would be better not to rely on calling out to WebCore just to achieve a
cross-platform timer implementation. I would nix the WebCore code, and, as you
suggested, add a FIXME explaining how other platforms can get the right
behavior by porting the WebCore timer code to WTF.

The canonical name we use for platform-speicifc data structure is Platform*. In
this case, DefaultGCActivityCallbackPlatformData.

Please post SunSpider results for this change.