[webkit-reviews] review denied: [Bug 42387] SVG - stroke-width:0 bug with stroke other than "none" : [Attachment 61848] stroke-width:0 fix

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has denied Fady Samuel
<fsamuel at chromium.org>'s request for review:
Bug 42387: SVG - stroke-width:0 bug with stroke other than "none"
https://bugs.webkit.org/show_bug.cgi?id=42387

Attachment 61848: stroke-width:0 fix
https://bugs.webkit.org/attachment.cgi?id=61848&action=review

------- Additional Comments from David Levin <levin at chromium.org>
No need for chromium-mac results.


> diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
> index 0fc0719..dbd9b17 100644
> --- a/WebCore/ChangeLog
> +++ b/WebCore/ChangeLog
> @@ -1,3 +1,22 @@
> +2010-07-16  Fady Samuel  <fsamuel at chromium.org>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +	   
> +	   Avoids adding stroke when stroke-width is zero.

Move to function level in the changelog (and put "Ditto." after the first
function).

(because function level comments are preferred in WK ChangeLogs.

> +
> +	   SVG - stroke-width:0 bug with stroke other than "none"
> +	   https://bugs.webkit.org/show_bug.cgi?id=42387
> +
> +	   Test: svg/stroke/path-zero-strokewidth-test.svg
> +
> +	   * platform/graphics/skia/GraphicsContextSkia.cpp:
> +	   (WebCore::GraphicsContext::drawConvexPolygon):

Right here (is what I mean by function level).

> +	   (WebCore::GraphicsContext::drawEllipse):
> +	   (WebCore::GraphicsContext::drawLine):
> +	   (WebCore::GraphicsContext::strokeArc):
> +	   (WebCore::GraphicsContext::strokePath):
> +	   (WebCore::GraphicsContext::strokeRect):
> +