[webkit-reviews] review granted: [Bug 42464] Really add WARN_UNUSED_RESULT to leakRef : [Attachment 61819] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 16 10:21:47 PDT 2010


David Levin <levin at chromium.org> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 42464: Really add WARN_UNUSED_RESULT to leakRef
https://bugs.webkit.org/show_bug.cgi?id=42464

Attachment 61819: Patch
https://bugs.webkit.org/attachment.cgi?id=61819&action=review

------- Additional Comments from David Levin <levin at chromium.org>
> diff --git a/JavaScriptCore/ChangeLog b/JavaScriptCore/ChangeLog
> +	   * wtf/RetainPtr.h:
> +	   (WTF::RetainPtr::releaseRef):
> +	   Remove WARN_UNUSED_RESULT here for now, it leads to two warnings
that need
> +	   to be fixed first.

fwiw, you appear to only have fixed one of them.


More information about the webkit-reviews mailing list