[webkit-reviews] review granted: [Bug 42462] Web Inspector: Clean-up Inspector interface generator. : [Attachment 61816] [patch] initial version.

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 42462: Web Inspector: Clean-up Inspector interface generator.
https://bugs.webkit.org/show_bug.cgi?id=42462

Attachment 61816: [patch] initial version.
https://bugs.webkit.org/attachment.cgi?id=61816&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
WebCore/inspector/CodeGeneratorInspector.pm:40
 +  };
Maybe accessorSuffix to be more specific?

WebCore/inspector/CodeGeneratorInspector.pm:104
 +  my $callId = new domSignature();
domSignature sounds weird to me

WebCore/inspector/CodeGeneratorInspector.pm:176
 +	my @argsFiltered = grep($_->direction eq "out",
@{$function->parameters});
Some comment would clarify this stuff.