[webkit-reviews] review denied: [Bug 25898] [Gtk] object:text-changed events should be emitted for entries and password text : [Attachment 61782] 2. New functions in AXObjectCache to call when text changes in a node
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jul 16 09:43:31 PDT 2010
chris fleizach <cfleizach at apple.com> has denied Mario Sanchez Prada
<msanchez at igalia.com>'s request for review:
Bug 25898: [Gtk] object:text-changed events should be emitted for entries and
password text
https://bugs.webkit.org/show_bug.cgi?id=25898
Attachment 61782: 2. New functions in AXObjectCache to call when text changes
in a node
https://bugs.webkit.org/attachment.cgi?id=61782&action=review
------- Additional Comments from chris fleizach <cfleizach at apple.com>
This patch is just about there. I'm putting review- just because i'd like to
see it one more time before it goes through. thanks!
WebCore/accessibility/AXObjectCache.cpp:473
+ }
it looks like you don't really need this method, since its only used by the
RenderObject version.
WebCore/accessibility/gtk/AXObjectCacheAtk.cpp:68
+
This looks like a roundabout way to get object->parentObject()->wrapper().
WebCore/accessibility/gtk/AXObjectCacheAtk.cpp:73
+
identation is wrong
WebCore/accessibility/gtk/AXObjectCacheAtk.cpp:88
+
identation is wrong
WebCore/accessibility/gtk/AXObjectCacheAtk.cpp:94
+ }
looks like you should use a switch statement here which sets a char* or String
to "text-change*". then you'd only have to call g_signal* one time.
WebCore/accessibility/win/AXObjectCacheWin.cpp:113
+ 1.7.0.4
extra line removal not needed
WebCore/accessibility/gtk/AXObjectCacheAtk.cpp:65
+
identation
More information about the webkit-reviews
mailing list