[webkit-reviews] review requested: [Bug 42367] Speech input plumbing in webkit : [Attachment 61809] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 16 08:31:15 PDT 2010


Satish Sampath <satish at chromium.org> has asked	for review:
Bug 42367: Speech input plumbing in webkit
https://bugs.webkit.org/show_bug.cgi?id=42367

Attachment 61809: Patch
https://bugs.webkit.org/attachment.cgi?id=61809&action=review

------- Additional Comments from Satish Sampath <satish at chromium.org>
Addressed all of Marcus's comments, except changing the name of
SpeechInputClientImpl to WebSpeechInputClientImpl. It looks to me that the
'Web' prefix is used primarily for interfaces/classes exposed from WebKit via
the headers in chromium/public directory. Majority of classes in chromium/src
doesn't have the 'Web' prefix and most of those which do have the prefix are
implementations of classes exposed in the chromium/public directory. I'm happy
to change the name if my understanding is incorrect and there is a strong
reason to have the 'Web' prefix even for classes internal to WebKit.


More information about the webkit-reviews mailing list