[webkit-reviews] review canceled: [Bug 21180] console.trace should show file and line number for each function in the stack : [Attachment 61791] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has canceled Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 21180: console.trace should show file and line number for each function in
the stack
https://bugs.webkit.org/show_bug.cgi?id=21180

Attachment 61791: Patch
https://bugs.webkit.org/attachment.cgi?id=61791&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
Formally correct, but I'd like you to use TreeOutline instead of a custom list.


WebCore/bindings/v8/ScriptCallStack.cpp:124
 +	if (m_stackTrace.get().IsEmpty())
Do we need a handle to stack trace here?

WebCore/bindings/v8/ScriptCallStack.h:76
 +	OwnPtr<ScriptCallFrame> m_topFrame;
Can we make it value type?

WebCore/bindings/v8/custom/V8ConsoleCustom.cpp:69
 +	v8::Local<v8::StackTrace> stackTrace =
v8::StackTrace::CurrentStackTrace(20000);
200?

WebCore/inspector/ConsoleMessage.cpp:140
 +		frames.set(i, m_frames.at(i).createFrontendObject(frontend));
buildObjectForFrame

WebCore/inspector/front-end/ConsoleView.js:832
 +		    var urlElement = this._createSourceUrlLink(this.url,
this.line);
_createSourceURLLink

WebCore/inspector/front-end/ConsoleView.js:844
 +		    var ol = this._createStackTraceElement();
You should use TreeOutline and TreeItem here.