[webkit-reviews] review denied: [Bug 42313] Enable window.webkitPerformance (Web Timing) for chromium : [Attachment 61755] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Tony Gentilcore
<tonyg at chromium.org>'s request for review:
Bug 42313: Enable window.webkitPerformance (Web Timing) for chromium
https://bugs.webkit.org/show_bug.cgi?id=42313

Attachment 61755: Patch
https://bugs.webkit.org/attachment.cgi?id=61755&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
LayoutTests/platform/chromium/fast/dom/Window/window-properties-performance-exp
ected.txt:1
 +  This test dumps all of the properties that are reachable from the
window.webkitPerformance object, along with their types.
this file should be unnecessary given the one here:
LayoutTests/fast/dom/Window/window-properties-performance-expected.txt

LayoutTests/platform/gtk/Skipped:5872
 +  http/tests/misc/webtiming-two-redirects.html
it seems like you should add fast/dom/Window/window-properties-performance.html
to
the Skipped files as well.  what point is there in testing that
webkitPerformance
is undefined for the ports that don't have webtiming enabled?  i think it is
better
to skip the test for those ports.  otherwise, to enable the feature, they have
to
delete the expected failure results, which is a bit unusual.