[webkit-reviews] review denied: [Bug 28771] Error properties of the Global Object are missing the DontEnum attribute : [Attachment 61643] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 15 22:22:12 PDT 2010


Sam Weinig <sam at webkit.org> has denied Kent Hansen <kent.hansen at nokia.com>'s
request for review:
Bug 28771: Error properties of the Global Object are missing the DontEnum
attribute
https://bugs.webkit.org/show_bug.cgi?id=28771

Attachment 61643: Patch
https://bugs.webkit.org/attachment.cgi?id=61643&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
r-. Since you are changing the DontEnum status of 6 properties, we should
really have tests that test all 6 properties. The existing tests only cover
EvalError.


More information about the webkit-reviews mailing list