[webkit-reviews] review granted: [Bug 42438] Add directional property enums to the switch in applyProperty : [Attachment 61758] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 15 19:55:46 PDT 2010


David Levin <levin at chromium.org> has granted Erik Arvidsson
<arv at chromium.org>'s request for review:
Bug 42438: Add directional property enums to the switch in applyProperty
https://bugs.webkit.org/show_bug.cgi?id=42438

Attachment 61758: Patch
https://bugs.webkit.org/attachment.cgi?id=61758&action=review

------- Additional Comments from David Levin <levin at chromium.org>
I wish there was a "cleaner" way of doing it. (In fact, I can think of one but
it involves macros and perhaps a little trickiness so maybe it wouldn't be that
great.)


Here's the shape of what I'm thinking of. A "header" file with a list like
this.
  CSS_DIRECTION_AWARE_PROPERTY(CSSPropertyWebkitMarginEnd,
CSSPropertyMarginRight, CSSPropertyMarginLeft)

Anyway what you have here will work.


More information about the webkit-reviews mailing list