[webkit-reviews] review denied: [Bug 42271] [chromium] PopupMenu labels are not very visible when selected : [Attachment 61738] Initial patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jul 15 15:56:14 PDT 2010
David Levin <levin at chromium.org> has denied Jay Civelli
<jcivelli at chromium.org>'s request for review:
Bug 42271: [chromium] PopupMenu labels are not very visible when selected
https://bugs.webkit.org/show_bug.cgi?id=42271
Attachment 61738: Initial patch
https://bugs.webkit.org/attachment.cgi?id=61738&action=review
------- Additional Comments from David Levin <levin at chromium.org>
> Index: WebCore/ChangeLog
> + (WebCore::PopupListBox::paintRow):
A short comment here would be nice.
> Index: WebCore/platform/chromium/PopupMenuChromium.cpp
> + gc->setFillColor(textColor, DeviceColorSpace);
labelColor (as discussed).
More information about the webkit-reviews
mailing list