[webkit-reviews] review denied: [Bug 34719] WebGL rendering results must be made available to Canvas.toDataURL and 2D drawImage : [Attachment 61712] revised patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 15 15:44:00 PDT 2010


Nate Chapin <japhet at chromium.org> has denied Zhenyao Mo <zmo at google.com>'s
request for review:
Bug 34719: WebGL rendering results must be made available to Canvas.toDataURL
and 2D drawImage
https://bugs.webkit.org/show_bug.cgi?id=34719

Attachment 61712: revised patch
https://bugs.webkit.org/attachment.cgi?id=61712&action=review

------- Additional Comments from Nate Chapin <japhet at chromium.org>

> +#if ENABLE(3D_CANVAS)
> +    if (sourceCanvas->is3D()) {
> +	   WebGLRenderingContext* context3d =
reinterpret_cast<WebGLRenderingContext*>(sourceCanvas->renderingContext());
> +	   context3d->paintRenderingResultsToCanvas();
> +    }
> +#endif
> +

We probably shouldn't be doing 3D things in CanvasRenderingContext2D.



> +  intervalId = window.setInterval(function() {

If there's any way to make this test work without setInterval, please do so,
lest it be slow and flaky.


More information about the webkit-reviews mailing list