[webkit-reviews] review granted: [Bug 42401] Query of NUM_COMPRESSED_TEXTURE_FORMATS must be handled by WebGL : [Attachment 61715] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 15 14:02:23 PDT 2010


Nate Chapin <japhet at chromium.org> has granted Kenneth Russell
<kbr at google.com>'s request for review:
Bug 42401: Query of NUM_COMPRESSED_TEXTURE_FORMATS must be handled by WebGL
https://bugs.webkit.org/show_bug.cgi?id=42401

Attachment 61715: Patch
https://bugs.webkit.org/attachment.cgi?id=61715&action=review

------- Additional Comments from Nate Chapin <japhet at chromium.org>
Per offline conversation, please add a comment explaining why we're hard-coding
a 0 before submitting.

>      case GraphicsContext3D::NUM_COMPRESSED_TEXTURE_FORMATS:
> -	   return getLongParameter(pname);
> +	   return WebGLGetInfo(static_cast<long>(0));


More information about the webkit-reviews mailing list