[webkit-reviews] review requested: [Bug 42177] [Chromium] Fix KURLGoogle and WEBKIT_IMPLEMENTATION for chromium multi-dll build : [Attachment 61705] New patch without chromium deps rolls (done in separate patch)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 15 13:30:14 PDT 2010


Victor Wang <victorw at chromium.org> has asked  for review:
Bug 42177: [Chromium] Fix KURLGoogle and WEBKIT_IMPLEMENTATION for chromium
multi-dll build
https://bugs.webkit.org/show_bug.cgi?id=42177

Attachment 61705: New patch without chromium deps rolls (done in separate
patch)
https://bugs.webkit.org/attachment.cgi?id=61705&action=review

------- Additional Comments from Victor Wang <victorw at chromium.org>
The chromium linux webkit break is due to the chromium deps roll. It is caused
by changes between the time the patch ran on cr-linux EWS and the time it was
actually landed.
Remove the chromium DEPS roll from this patch and did it separately:
http://trac.webkit.org/changeset/63446.
Also update gyp so c4291 warning is disabled for chromium multi dll build.


More information about the webkit-reviews mailing list