[webkit-reviews] review granted: [Bug 42387] SVG - stroke-width:0 bug with stroke other than "none" : [Attachment 61683] stroke-width:0 fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 15 10:37:48 PDT 2010


Darin Adler <darin at apple.com> has granted Fady Samuel <fsamuel at chromium.org>'s
request for review:
Bug 42387: SVG - stroke-width:0 bug with stroke other than "none"
https://bugs.webkit.org/show_bug.cgi?id=42387

Attachment 61683: stroke-width:0 fix
https://bugs.webkit.org/attachment.cgi?id=61683&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
There's an extra change log entry in there.

>      } else
> -	   platformContext()->setupPaintForStroking(&paint, 0, 0);
> +	   if (!platformContext()->setupPaintForStroking(&paint, 0, 0))
> +	       return;

Need to add braces here because this is now a multi-line else body.

Otherwise looks fine. r=me


More information about the webkit-reviews mailing list